feat(breaking): fail task on async command failure #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
pushed a commit
to denoland/deno
that referenced
this pull request
Oct 18, 2022
Tests and implementation are found here: denoland/deno_task_shell#59 This is a breaking change, but `deno task` is unstable. > This changes async commands so that on non-zero exit code they will fail the entire task. For example: > > ```jsonc > // task that asynchronously starts a server and starts a watcher for the frontend > "dev": "deno task server & deno task frontend:watch" > ``` > > Previously when running `deno task dev`, if `deno task server` failed, the entire command would not fail, which kept in line with `sh`, but it's not very practical. This change causes `deno task dev` to fail. > > To opt out, developers can add an `|| exit 0`: > > ```jsonc > "dev": "deno task server || exit 0 & deno task frontend:watch" > ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes async commands so that on non-zero exit code they will fail the entire task. For example:
Previously when running
deno task dev, ifdeno task serverfailed, the entire command would not fail, which kept in line withsh, but it's not very practical. This change causesdeno task devto fail.To opt out, developers can add an
|| exit 0:Closes #50