Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

feat: web workers #46

Merged
merged 13 commits into from
Jan 25, 2023
Merged

feat: web workers #46

merged 13 commits into from
Jan 25, 2023

Conversation

lino-levan
Copy link
Contributor

Two quick notes:

  • This is where [WIP] Add 'Module metadata' #1 would have been nice to link to as an "@ see". I will probably open another PR for that.
  • I think this article would be incomplete without the permissions example, but permissions in web workers are unstable. I could aways remove it for now and add it again when/if it gets stabilized (there are definitely some ethical implications of extending the web standard spec)? Thoughts @kt3k?

crowlKats
crowlKats reviewed Jan 14, 2023
View reviewed changes
data/web-workers.ts Outdated Show resolved Hide resolved
data/web-workers.ts Outdated Show resolved Hide resolved
data/web-workers.ts Outdated Show resolved Hide resolved
data/web-workers.ts Outdated Show resolved Hide resolved
@lino-levan @crowlKats
Update data/web-workers.ts
58444c8 
Co-authored-by: Leo Kettmeir <crowlkats@toaxl.com>
@lino-levan @crowlKats
Update data/web-workers.ts
54546e9 
Co-authored-by: Leo Kettmeir <crowlkats@toaxl.com>
@lino-levan @crowlKats
Update data/web-workers.ts
d6ca108 
Co-authored-by: Leo Kettmeir <crowlkats@toaxl.com>
@lino-levan lino-levan requested review from crowlKats and removed request for lucacasonato January 15, 2023 00:35
crowlKats
crowlKats reviewed Jan 15, 2023
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still find this fairly confusing to read

@lino-levan
Copy link
Contributor Author

I feel like this is an important example, but I have no idea what the wording should be. Any ideas?

@crowlKats
Copy link
Member

@lino-levan maybe putting the worker.sendMessage call bellow the worker file could work

@lino-levan

This comment was marked as outdated.

Sign in to view
@lino-levan
Copy link
Contributor Author

@kt3k please take a look!

kt3k
kt3k reviewed Jan 24, 2023
View reviewed changes
data/web-workers.ts Outdated Show resolved Hide resolved
@kt3k
Copy link
Member

kt3k commented Jan 24, 2023

The content looks fine to me

kt3k
kt3k approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 105d091 into denoland:main Jan 25, 2023
@lino-levan lino-levan deleted the feat-web-workers branch January 31, 2023 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crowlKats crowlKats crowlKats left review comments

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lino-levan @crowlKats @kt3k