Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace import.meta.main in CJS #133

Merged
merged 2 commits into from
Feb 23, 2022
Merged

feat: replace import.meta.main in CJS #133

merged 2 commits into from
Feb 23, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Feb 23, 2022

closes #106

This PR replaces import.meta.main with (require.main === module).

@CLAassistant
Copy link

CLAassistant commented Feb 23, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

dsherret
dsherret approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @kt3k!

@dsherret dsherret merged commit 92f1b8b into denoland:main Feb 23, 2022
@kt3k kt3k deleted the feat/import-main branch February 23, 2022 03:31
@scarf005 scarf005 mentioned this pull request Feb 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support import.meta.main
3 participants
@kt3k @CLAassistant @dsherret