Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add internalWasmUrl option #323

Merged
merged 3 commits into from
Jul 19, 2023
Merged

feat: add internalWasmUrl option #323

merged 3 commits into from
Jul 19, 2023

Conversation

Gaubee
Copy link
Contributor

@Gaubee Gaubee commented Jul 10, 2023

users can provide their own wasm path to meet the needs of some special situations.

@Gaubee
✨ add wasmUrl options
5d5de9a 
users can provide their own wasm path to meet the needs of some special situations.
@Gaubee
Copy link
Contributor Author

Gaubee commented Jul 10, 2023

image
when I test dnt in locale, the import.meta.url starts with file:, so I need to provide the wasmUrl by my self.

@dsherret dsherret changed the title ✨ add wasmUrl options feat: add internalWasmUrl option Jul 19, 2023
dsherret
dsherret approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! I renamed it to internalWasmUrl just to be a bit clear that most users won't need to use this.

@dsherret dsherret merged commit 45c5006 into denoland:main Jul 19, 2023
2 checks passed
@Gaubee
Copy link
Contributor Author

Gaubee commented Jul 19, 2023

I ues it with etag, to void cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gaubee @dsherret