Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skipNpmInstall option #339

Merged
merged 3 commits into from
Nov 14, 2023
Merged

feat: add skipNpmInstall option #339

merged 3 commits into from
Nov 14, 2023

Conversation

DerZade
Copy link
Contributor

@DerZade DerZade commented Oct 5, 2023

This PR adds a skipInstallDeps option (false by default), which allows to skip the npm install step (or whatever package manager you're using).

Motivation

I would like to include a prepare-script in an npm package. This prepare-script runs automatically during npm install, which I would like to avoid.

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, but this also means that type checking or tests will likely fail. Probably what would be best is to edit the package.json to add the prepare script in the postBuild hook.

mod.ts Outdated Show resolved Hide resolved
mod.ts Outdated Show resolved Hide resolved
@dsherret dsherret changed the title feat: add skipInstallDeps option feat: add skipNpmInstall option Nov 14, 2023
@dsherret dsherret merged commit 606645e into denoland:main Nov 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants