This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
fix: Hashes in links do not properly anchor to items in the page #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Router does not scroll to an anchor when a link in a page gets clicked. I have applied this fix to resolve the issue: remix-run/react-router#394 (comment).
I also fixed that the docs re download data when search parameters or the hash in the location changes. It now only downloads data when the path changes. This means that there are now a lot less unnecessary reloads.
There is currently still an issue with anchoring when first navigating to a page (eg. going to https://deno.land/std/bytes/mod.ts?doc#findIndex won't actually anchor to findIndex as this element is not there on first load - because of client side rendering). This PR doesn't change this behavior. To fix this we need to add some code that manually scrolls to a certain tag after the content has been loaded. This might become somewhat messy, so Ill tackle that in a separate PR so we can discuss exactly how we want to do this.