fix: Missing error on invalid island children #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinhagemeister
changed the title
marvinhagemeister
force-pushed
the
invalid-island-children
branch
from
f199bfe
to
02a7d8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1674 a reproduction was posted where a json object was passed to an island instead of an expected JSX element.
Whilst this is technically possible in Preact, if the receiving component knows how to deal with that, it's not something that's encouraged. It breaks the compositional nature of components and leads to difficult to understand errors.
Instead users should pass data via any other prop where the already existing serialization mechanism we have in Fresh will kick in. The
childrenprop is reserved for JSX nodes only.All this PR does, is throw an error when it detects that the user is trying to pass something invalid via
childrento an island