Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

docs: add the native lsp for neovim #57

Closed
wants to merge 3 commits into from

Conversation

TeoDev1611
Copy link

@TeoDev1611 TeoDev1611 commented Aug 20, 2021

Add documentation for the new native lsp in neovim

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2021

CLA assistant check
All committers have signed the CLA.

@David-Else
Copy link
Contributor

I don't think it makes logical sense to have the Native Lsp subheading under Vim/Neovim as it does not apply to Vim. I think a new heading is needed for Neovim 0.5+ Native LSP. Then we can drop and the Native Lsp support this via Deno Language Server with some tools.. That section is somewhat confusing.

Also there are a few grammatical errors like And is ready deno, and the plugin names would be better as hyper-links to the repositories.

Having Any completion engine like Compe, Coq, Completion.nvim, ddc.nvim etc. implies that they are needed for the LSP. which is not actually the case. You actually don't technically need nvim-lspconfig, but it is a good idea to use it as it contains well thought out default LSP settings.

Sorry to appear so critical, thanks for adding this important info! I would be happy to make a brand new pull request including all these changes if you like? It would be a total re-write.

@TeoDev1611
Copy link
Author

@David-Else okay I will make this suggestions tomorrow 🙂

@David-Else
Copy link
Contributor

I am afraid this is written in a very confusing way with multiple grammatical errors.

The main point that the native Neovim language server can be used was added in https://github.com/denoland/manual/pull/53/files . It would be nice to have a separate sub heading of Neovim built in language server with some more details, but it needs to be very clear and easy to understand.

@bartlomieju
Copy link
Member

@David-Else I welcome all PRs! Unfortunately I don't use Neovim, but if you have experience setting it up, we'd appreciate updated instructions.

@bartlomieju
Copy link
Member

Closing in favor of #130

@TeoDev1611 TeoDev1611 deleted the native-lsp-neovim branch November 7, 2021 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants