Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .tool-versions and .dvmrc support #61

Merged
merged 16 commits into from
Jul 5, 2024

Conversation

jessedijkstra
Copy link
Contributor

Adds support for both .tool-versions and .dvmrc, implementation mirrors that of setup-node

@jessedijkstra
Copy link
Contributor Author

@kt3k could you take a look at this? Currently required to use asdf in a repository that uses Deno but rather use the setup-deno action with .tool-versions.

@kt3k
Copy link
Member

kt3k commented May 16, 2024

Thanks for your contribution!

Can you add test cases in .github/workflows/test.yml? Probably by adding something like the below (together with fixture .dvmrc and .tool-versions files) :

  # ...
  test-version-file:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        file: [".tool-versions", ".dvmrc"]
    steps:
      - uses: actions/checkout@v3

      - name: Setup Deno
        uses: ./
        with:
          deno-version-file: ${{ matrix.file }}

      - name: Check version
        run: deno -V | grep -q "deno 1\.43\.1"

Signed-off-by: Jesse Dijkstra <mail@jessedijkstra.nl>
Signed-off-by: Jesse Dijkstra <mail@jessedijkstra.nl>
Signed-off-by: Jesse Dijkstra <mail@jessedijkstra.nl>
@jessedijkstra
Copy link
Contributor Author

jessedijkstra commented Jul 2, 2024

@kt3k found a bug and fixed it by adding the tests, please take a look again when you have time.

@jessedijkstra
Copy link
Contributor Author

Btw, based on the work of #54 :)

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit edde936 into denoland:main Jul 5, 2024
17 checks passed
@kt3k kt3k mentioned this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants