-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .tool-versions and .dvmrc support #61
Add .tool-versions and .dvmrc support #61
Conversation
@kt3k could you take a look at this? Currently required to use asdf in a repository that uses Deno but rather use the setup-deno action with .tool-versions. |
Thanks for your contribution! Can you add test cases in # ...
test-version-file:
runs-on: ubuntu-latest
strategy:
matrix:
file: [".tool-versions", ".dvmrc"]
steps:
- uses: actions/checkout@v3
- name: Setup Deno
uses: ./
with:
deno-version-file: ${{ matrix.file }}
- name: Check version
run: deno -V | grep -q "deno 1\.43\.1" |
Signed-off-by: Jesse Dijkstra <mail@jessedijkstra.nl>
Signed-off-by: Jesse Dijkstra <mail@jessedijkstra.nl>
Signed-off-by: Jesse Dijkstra <mail@jessedijkstra.nl>
@kt3k found a bug and fixed it by adding the tests, please take a look again when you have time. |
Btw, based on the work of #54 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Adds support for both .tool-versions and .dvmrc, implementation mirrors that of setup-node