Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(bytes): move to single-export files #2955

Merged
merged 1 commit into from
Nov 29, 2022
Merged

refactor(bytes): move to single-export files #2955

merged 1 commit into from
Nov 29, 2022

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Nov 29, 2022 •
edited
Loading

This is part of #2936, which aims for leaner dependencies and a more straightforward structure by only having one export per file within the bytes module.

This PR also:

  1. Removes the exporting of equalsNaive and equals32Bit, as they're private functions.
  2. Removes the likely no longer needed equals_bench.ts.

@iuioiua iuioiua marked this pull request as ready for review November 29, 2022 05:31
@iuioiua iuioiua requested a review from kt3k as a code owner November 29, 2022 05:31
kt3k
kt3k approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@kt3k kt3k merged commit e1117a8 into denoland:main Nov 29, 2022
@iuioiua iuioiua deleted the refactor-bytes branch November 29, 2022 06:01
@iuioiua iuioiua mentioned this pull request Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k