Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): add os.version #2962

Merged
merged 1 commit into from
Dec 1, 2022
Merged

feat(node): add os.version #2962

merged 1 commit into from
Dec 1, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Nov 30, 2022

This PR implements os.version. The returned value is not identical to Node.js version, but it's sufficient for passing test-os.js and enabling deno run npm:next info command.

related: denoland/deno#16679

cjihrig
cjihrig approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for a start. LGTM

@lino-levan
Copy link
Contributor

LGTM

@kt3k kt3k merged commit 7c84b06 into denoland:main Dec 1, 2022
@kt3k kt3k deleted the shim-node-os-version branch December 1, 2022 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kt3k @lino-levan @cjihrig