Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(io): rework single-export files #3056

Merged
merged 2 commits into from
Dec 26, 2022
Merged

refactor(io): rework single-export files #3056

merged 2 commits into from
Dec 26, 2022

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Dec 26, 2022

This change simplifies how functions and types are re-exported while maintaining deprecation warnings introduced in #2975. This also fixes an issue blocking denoland/deno#16881.

CC @bartlomieju

@iuioiua
Copy link
Contributor Author

iuioiua commented Dec 26, 2022

Note to self: this needs to be done, as a proactive measure, for the archive and streams modules.

@iuioiua iuioiua marked this pull request as ready for review December 26, 2022 11:45
@iuioiua iuioiua requested a review from kt3k as a code owner December 26, 2022 11:45
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's continue on denoland/deno#16881 with this change

@kt3k kt3k merged commit 6780254 into denoland:main Dec 26, 2022
@lino-levan
Copy link
Contributor

@iuioiua Congrats on your 100th commit to deno_std 🎉🎉🎉

@iuioiua iuioiua deleted the rework-io-restructure branch December 26, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants