Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: repoint internal imports to single-export files #3537

Merged
merged 2 commits into from
Aug 14, 2023
Merged

chore: repoint internal imports to single-export files #3537

merged 2 commits into from
Aug 14, 2023

Conversation

0f-0b
Copy link
Contributor

@0f-0b 0f-0b commented Aug 13, 2023

This PR changes a few internal imports to point to single-export files instead of their corresponding mod.ts files. As a result, the total size of http/file_server.ts and its dependencies is reduced by about 12%.

$ deno info https://deno.land/std@0.198.0/http/file_server.ts
…
dependencies: 57 unique
size: 367.76KB
…

$ deno info ./http/file_server.ts
…
dependencies: 34 unique
size: 323.66KB
…

@0f-0b 0f-0b requested a review from kt3k as a code owner August 13, 2023 19:36
kt3k
kt3k approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring with perf improvements! Thanks!

LGTM

json/concatenated_json_parse_stream_test.ts
@@ -325,7 +325,7 @@ Deno.test({
[`{${"foo".repeat(100)}}`],
{},
SyntaxError,
`Expected property name or '}' in JSON at position 1 (parsing: '{foofoofoofoofoofoofoofoofoofo...')`,
`Expected property name or '}' in JSON at position 1 (line 1 column 2) (parsing: '{foofoofoofoofoofoofoofoofoofo...')`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@kt3k kt3k merged commit 159060b into denoland:main Aug 14, 2023
8 checks passed
@kt3k kt3k mentioned this pull request Aug 14, 2023
Closed
@0f-0b 0f-0b deleted the debloat branch August 14, 2023 07:10
mooxl pushed a commit to mooxl/deno_std that referenced this pull request Aug 14, 2023
@0f-0b @mooxl
perf: repoint internal imports to single-export files (denoland#3537)
7560048
mooxl added a commit to mooxl/deno_std that referenced this pull request Aug 14, 2023
@mooxl
Revert "perf: repoint internal imports to single-export files (denola…
1196506 
…nd#3537)"

This reverts commit 7560048.
mooxl pushed a commit to mooxl/deno_std that referenced this pull request Aug 14, 2023
@0f-0b @mooxl
perf: repoint internal imports to single-export files (denoland#3537)
93df1c7
mooxl added a commit to mooxl/deno_std that referenced this pull request Aug 14, 2023
@mooxl
Revert "perf: repoint internal imports to single-export files (denola…
823380e 
…nd#3537)"

This reverts commit 7560048.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
dotenv fs http json testing wasi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0f-0b @kt3k