Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(front_matter): deprecate language-specific test functions #3654

Merged
merged 1 commit into from
Oct 11, 2023
Merged

BREAKING(front_matter): deprecate language-specific test functions #3654

merged 1 commit into from
Oct 11, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 19, 2023

This PR deprecates language specific test functions. This PR makes front_matter module aligned to single-export pattern together with #3653 #3641

part of #3601 #3489

@kt3k kt3k changed the title BREAKING(front_matter): deprecated specific functions BREAKING(front_matter): deprecated language-specific test functions Sep 19, 2023
@kt3k kt3k changed the title BREAKING(front_matter): deprecated language-specific test functions BREAKING(front_matter): deprecate language-specific test functions Sep 19, 2023
@kt3k
Copy link
Member Author

kt3k commented Sep 25, 2023

The motivation of this is:

  1. to make front_matter conformant to single-export pattern
  2. test seems like an advanced usage of front matter (extract is the basic way to use it). So we probably don't need to expose test for each language, but it probably is sufficient to provide only generic test function, which supports all combination of languages.

iuioiua
iuioiua approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lino-levan
lino-levan approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@lino-levan lino-levan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Anything keeping this open? Just waiting for community feedback?

lucacasonato
lucacasonato approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 5e7d99d into denoland:main Oct 11, 2023
8 checks passed
@kt3k kt3k deleted the deprecate-front-matter-test branch October 11, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@lino-levan lino-levan lino-levan approved these changes

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
front-matter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kt3k @lucacasonato @lino-levan @iuioiua