Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flags): correct deprecation notices #4207

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jan 16, 2024

Fixes #4203

Normally, we'd call parseArgs() within parse(). However, parseArgs() is so complex with all its type arguments, one cannot simply do so. I figured the next best thing to do is copy the entire std/cli/parse_args.ts implementation. I did this instead of reverting to the old std/flags code, as the new code has minor tweaks that enable the noUncheckedIndexedAccess compiler option.

@iuioiua iuioiua requested a review from kt3k as a code owner January 16, 2024 01:36
@github-actions github-actions bot added the flags label Jan 16, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 3d0c810 into main Jan 16, 2024
12 checks passed
@iuioiua iuioiua deleted the fix-flags-deprecations branch January 16, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse of std/flags is not marked deprecated in API doc
2 participants