Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(webgpu): remove Deno.resources() usage #4708

Merged
merged 2 commits into from
May 10, 2024

Conversation

crowlKats
Copy link
Member

Possible due to denoland/deno#23752

@crowlKats crowlKats requested a review from kt3k as a code owner May 10, 2024 10:26
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.47%. Comparing base (c53ca87) to head (6297c71).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4708      +/-   ##
==========================================
- Coverage   91.48%   91.47%   -0.01%     
==========================================
  Files         477      477              
  Lines       37273    37268       -5     
  Branches     5316     5316              
==========================================
- Hits        34098    34091       -7     
- Misses       3119     3121       +2     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title tests(webgpu):remove Deno.resources usage test(webgpu): remove Deno.resources() usage May 10, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Glad to see this done 👍🏾

@iuioiua
Copy link
Contributor

iuioiua commented May 10, 2024

Merging as this seems to be blocking other PRs.

@iuioiua iuioiua merged commit 6deab72 into denoland:main May 10, 2024
13 checks passed
@crowlKats crowlKats deleted the update-webgpu-tests branch May 10, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants