fix(io/buffer): make Buffer compatible with Deploy #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
reviewed
May 11, 2021
io/buffer.ts
Outdated
| @@ -1,6 +1,14 @@ | |||
| import { assert } from "../_util/assert.ts"; | |||
| import { copy } from "../bytes/mod.ts"; | |||
|
|
|||
| interface Reader { | |||
There was a problem hiding this comment.
does it make sense to have a io/types.d.ts and put the Reader*/Writer*, etc and then import type from there? It would solve part of denoland/deno#9795. I wouldn't necessarily refactor all of io to use them at the moment, but it would be better than just burying them in buffer.ts while all of io and other std modules should move over to these.
There was a problem hiding this comment.
That would make more sense and sounds natural. Updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes type error of
io/bufferin Deploy environment by inliningReader/ReaderSyncinterafaces.This enables deploy script using, for example,
encoding/yamlmodule without type error withdeployctl run. https://gist.github.com/kt3k/43e25efffc6e1c360fc64274ea0381ebcloses #907