Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-enable extension when deno.json/deno.jsonc is present #880

Closed
boywithkeyboard opened this issue Jul 13, 2023 · 5 comments · Fixed by #902
Closed

Auto-enable extension when deno.json/deno.jsonc is present #880

boywithkeyboard opened this issue Jul 13, 2023 · 5 comments · Fixed by #902
Assignees
@nayeemrmn
Labels
enhancement New feature or request high priority

Comments

@boywithkeyboard
Copy link

It'd be awesome if the extension could by default look for a deno.json or deno.jsonc file and if one of the two is available, set deno.enable automatically to true.

Why?

A lot of Deno projects (e.g. the std library) don't configure deno.enable for just the workspace, making it annoying for people who don't have deno.enable set to true globally.

Also, this would allow us to have one file less in our codebases. :)
@boywithkeyboard
Copy link
Author

There could also be a globally set option which the users can opt in/out for this behavior.

@bartlomieju bartlomieju added enhancement New feature or request high priority labels Jul 26, 2023
@bartlomieju
Copy link
Member

@dsherret and I discussed this recently and it's something we definitely want to look at. Having deno.json in the root of the workspace should enable the extension automatically without any configuration from VSCode.

@boywithkeyboard
Copy link
Author

@bartlomieju awesome to hear!

@felipecrs
Copy link

@bartlomieju has this been assigned to someone already?

@bartlomieju
Copy link
Member

@felipecrs, no, not yet.

@felipecrs felipecrs mentioned this issue Aug 1, 2023
Closed
@nayeemrmn nayeemrmn self-assigned this Aug 30, 2023
This was referenced Aug 31, 2023
Merged
Merged
nayeemrmn added a commit to denoland/deno that referenced this issue Aug 31, 2023
@nayeemrmn
feat(lsp): enable via config file detection (#20334)
c0dcf6a 
With denoland/vscode_deno#902 for
denoland/vscode_deno#880.

For multi-folder workspaces, note that this only scans the first one and
applies the result to all. That means users would have to still have to
specify `"deno.enable": true/false` for their secondary folders if the
preference is different for those.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nayeemrmn nayeemrmn

Labels
enhancement New feature or request high priority
Projects
None yet
Milestone
No milestone
4 participants
@bartlomieju @felipecrs @nayeemrmn @boywithkeyboard