Enable optional 'eventName' in removeAllListeners #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mod.ts
Outdated
| if (this.events.has(eventName)) { | ||
| const listeners = (this.events.get(eventName) as Function[]).slice(); // Create a copy; We use it AFTER it's deleted. | ||
| this.events.delete(eventName); |
There was a problem hiding this comment.
I'm not sure why this is removed. If there's no events, this.events.has(eventName) should return false imho. I think this should be reverted, but I'm open to hear your opinion.
There was a problem hiding this comment.
@ozjd You're right! I'll revert!
mod.ts
Outdated
| } else { | ||
| const eventList: [string | symbol] = this.eventNames(); | ||
| eventList.map((value: string) => { | ||
| this.events.set(value, []); |
There was a problem hiding this comment.
Again, I think delete should be the function used here.
Additionally, this.emit("removeListener... isn't called. It would be possible for this function to call itself on each item in the map()'s callback.
eg. this.removeAllListeners(value)
|
LGTM! Thanks @Balou9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have enabled
eventNameto be optional. #5