Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI options are overwritten #32

Closed
timonson opened this issue May 11, 2020 · 1 comment
Closed

CLI options are overwritten #32

timonson opened this issue May 11, 2020 · 1 comment
Labels
bug Something isn't working
Milestone
2.1.0

Comments

@timonson
Copy link

timonson commented May 11, 2020 •
edited
Loading

This is caused by applyIfDefined here https://github.com/eliassjogreen/denon/blob/master/denon.ts#L51. For example it overwrites flags.deno_args with an empty array (if you don't use a config file).
I didn't make a PR because there are different logical ways to fix this and I don't know your preference.
@timonson timonson changed the title CLI options are overwritten by config CLI options are overwritten May 11, 2020
@eliassjogreen eliassjogreen added the bug Something isn't working label May 14, 2020
PabloSzx added a commit to PabloSzx/denon that referenced this issue May 16, 2020
@PabloSzx
arguments as source of truth
4129215 
fixes denosaurs#32
@PabloSzx PabloSzx mentioned this issue May 16, 2020
Closed
PabloSzx added a commit to PabloSzx/denon that referenced this issue May 16, 2020
@PabloSzx
arguments as source of truth
791b337 
fixes denosaurs#32
PabloSzx added a commit to PabloSzx/denon that referenced this issue May 16, 2020
@PabloSzx
arguments as source of truth
ad861c2 
fixes denosaurs#32
PabloSzx added a commit to PabloSzx/denon that referenced this issue May 16, 2020
@PabloSzx
arguments as source of truth
30372d7 
fixes denosaurs#32
@notfilippo notfilippo added this to the 2.0.0 milestone May 18, 2020
@notfilippo
Copy link
Collaborator

Closing as it is already implemented in rework branch. (see 4e71708)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

CLI arguments priority PabloSzx/denon
3 participants
@notfilippo @eliassjogreen @timonson