-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support going to type definition with tsserver #3545
Support going to type definition with tsserver #3545
Conversation
ALE migrated from Travis to Github Actions (see #3548) so it is necessary to rebase this PR from latest master branch to trigger the required checks.
|
Thanks for calling this out @hsanson ! I'll take care of that |
6f755b3
to
da201a8
Compare
FYI, I needed to update my remote connection to use SSH for auth rather than HTTP, due to something around workflow permissions. I don't know if that has something to do with my personal authentication permissions, or if that's an across-the-board requirement, but I've run into issues wit forks, GitHub Actions and HTTP auth in the past as well |
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
As far as I know, things should be working here -- I'm not sure why the checks appear to be stalled out. Is there something I can do @w0rp ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll commit that suggestion and merge this. Sorry I didn't look at it for so long. I've been variously busy and/or demoralised from the pandemic. I'm glad @hsanson has been around to get things merged in my absence.
Cheers! 🍻 |
Thanks @w0rp! The delay is no trouble at all😀 |
ale.vim
supports going to a type definition,tsserver
supports going to a type definition, butale.vim
doesn't support usingtsserver
to go to a type definition!This adds support for going to a type definition using
tsserver
.I added tests to the best of my ability by duplicating/altering some of the existing tests. I ran the
./run-tests
script locally and everything seems to be passing, but let me know if there are parts that I missed!