Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support going to type definition with tsserver #3545

Merged
merged 2 commits into from
Feb 20, 2021

Conversation

alexlafroscia
Copy link
Contributor

ale.vim supports going to a type definition, tsserver supports going to a type definition, but ale.vim doesn't support using tsserver to go to a type definition!

This adds support for going to a type definition using tsserver.

I added tests to the best of my ability by duplicating/altering some of the existing tests. I ran the ./run-tests script locally and everything seems to be passing, but let me know if there are parts that I missed!

@hsanson
Copy link
Contributor

hsanson commented Jan 22, 2021

ALE migrated from Travis to Github Actions (see #3548) so it is necessary to rebase this PR from latest master branch to trigger the required checks.

# Add dense-analysis as remote upstream on your local fork. Not 
# needed if already added.
git remote add upstream https://github.com/dense-analysis/ale.git

# Sync your local master with upstream master
git checkout master
git fetch upstream master
git merge upstream/master

# Rebase the PR branch with master
git checkout my-branch-name
git rebase master   # Fix any conflicts you may have

# Force push the updated PR branch to origin to trigger the checks
git push -f origin my-branch-name

@alexlafroscia
Copy link
Contributor Author

alexlafroscia commented Jan 22, 2021

Thanks for calling this out @hsanson ! I'll take care of that

@alexlafroscia
Copy link
Contributor Author

FYI, I needed to update my remote connection to use SSH for auth rather than HTTP, due to something around workflow permissions. I don't know if that has something to do with my personal authentication permissions, or if that's an across-the-board requirement, but I've run into issues wit forks, GitHub Actions and HTTP auth in the past as well

@hsanson hsanson requested a review from w0rp January 22, 2021 16:25
@stale
Copy link

stale bot commented Feb 19, 2021

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Feb 19, 2021
@alexlafroscia
Copy link
Contributor Author

As far as I know, things should be working here -- I'm not sure why the checks appear to be stalled out. Is there something I can do @w0rp ?

@stale stale bot removed the stale PRs a bot will close automatically label Feb 19, 2021
w0rp
w0rp previously approved these changes Feb 20, 2021
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll commit that suggestion and merge this. Sorry I didn't look at it for so long. I've been variously busy and/or demoralised from the pandemic. I'm glad @hsanson has been around to get things merged in my absence.

autoload/ale/definition.vim Outdated Show resolved Hide resolved
@w0rp w0rp merged commit d340710 into dense-analysis:master Feb 20, 2021
@w0rp
Copy link
Member

w0rp commented Feb 20, 2021

Cheers! 🍻

@alexlafroscia
Copy link
Contributor Author

Thanks @w0rp! The delay is no trouble at all😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants