Use stdin/out for cmake-format #3725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmake-format added support for reading from/outputting to stdin/out as of v0.3.6, released 2018-04-10 (commit 2e2aff2) [0]. Reading from stdin is preferable over reading from a temporary file because when given a concrete file cmake-format will look for its config file (.cmake-format.py or similar) in the parent directories of the provided file. If the temporary file is off in a tmpdir somewhere (e.g., /tmp on *nix), cmake-format will almost certainly not come across the user's intended format configuration file, making it appear that cmake-format is ignoring the config file. If cmake-format reads from stdin, though, it'll look for its config file in its current working directory and its parent directories, in a similar manner to clang-format. This has a much higher chance of running across the intended config file. [0]: https://github.com/cheshirekow/cmake_format/releases/tag/v0.3.6
|
I believe this solves #2624. It Works On My Machine™️, at least. |
hsanson
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake-format added support for reading from/outputting to stdin/out as
of v0.3.6, released 2018-04-10 (commit 2e2aff2) 0.
Reading from stdin is preferable over reading from a temporary file
because when given a concrete file cmake-format will look for its config
file (.cmake-format.py or similar) in the parent directories of the
provided file. If the temporary file is off in a tmpdir somewhere (e.g.,
/tmp on *nix), cmake-format will almost certainly not come across the
user's intended format configuration file, making it appear that
cmake-format is ignoring the config file.
If cmake-format reads from stdin, though, it'll look for its config file
in its current working directory and its parent directories, in a
similar manner to clang-format. This has a much higher chance of running
across the intended config file.