Deduplicate items in location list #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR to deduplicate items added to the location list.
I recently added a hook to the Nvim LSP configuration to pipe all of its diagnostics through ALE. This works really well, except that there are often duplicate issues found by the LSP and ALE linters. This is a small change that simply deduplicates those entries.
I did not add a new test as the existing
test_quickfix_deduplicationtest already covers deduplication. Let me know if you still want an additional test though.N.B. I originally wrote this to be configurable with a new option
g:ale_deduplicate_loclist, but in the spirit of avoiding adding more configuration levers than necessary I simply made it the default. If you think this should be configurable, let me know and I'll update the PR with a config option.