Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use tempfiles for ansible lint #3846

Merged
merged 3 commits into from
Jul 31, 2021
Merged

Do not use tempfiles for ansible lint #3846

merged 3 commits into from
Jul 31, 2021

Conversation

henrik-farre
Copy link
Contributor

@henrik-farre henrik-farre commented Jul 30, 2021

This changes the linter for ansible to not use temporary files by setting lint_file: 1 and changing the command from using stdin to %s.

Should fix #1814 completely

Linting tests pass, and I've verified that errors and warnings from running ansible-lint on the command line match the errors in ALE

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need to be updated too.

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@hsanson hsanson merged commit 056fbd0 into dense-analysis:master Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ansible-lint should not work on temp files
2 participants