Add cspell Linter #3981
Merged
Add cspell Linter #3981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsanson
requested changes
Nov 18, 2021
There was a problem hiding this comment.
Thanks for all the work... looks really good. Sorry to ask but can you also add the documentation changes:
- Add a section to doc/ale.txt with cspell configuration options. See ale-write-good-options for an example.
- Add sections to each supported language that link to the section in doc/ale.txt. See for example the ale-asciidoc-write-good section in the doc/ale-asciidoc.txt help file.
- Add cpell entry for each supported language in doc/ale-supported-languages-and-tools.txt. Note that sort order of the entries is important or linter test would fail.
- Add cspell entry for each supported language in supported-tools.md file. Ensure the same ordering is used on both doc/ale-supported-languages-and-tools.txt and supported-tools.md files.
Add cspell linter, with the languages it supports. Signed-off-by: David Houston <houstdav000@gmail.com>
Add documentation to /doc/ale.txt with cspell configuration options. Signed-off-by: David Houston <houstdav000@gmail.com>
Add cspell for each supported language, adding some spaces and removing others when caught navigating the file. Signed-off-by: David Houston <houstdav000@gmail.com>
hsanson
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
cspelllinter, with the languages it supports.Took a bit of reading to figure out some test problems, but I think I got it working pretty well.
Supported dictionaries can be found/added at https://github.com/streetsidesoftware/cspell-dicts
Closes #3828 and #3970