Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-fixer for crystal #4016

Conversation

grepsedawk
Copy link
Contributor

Where are the tests? Have you added tests? Have you updated the tests? Read the
comment above and the documentation referenced in it first. Write tests!

Seriously, read :help ale-dev and write tests.

@grepsedawk grepsedawk force-pushed the jewelcrafting-level-5--autofix-unlocked branch 2 times, most recently from dc3a923 to d3b2d5c Compare December 19, 2021 03:21
@grepsedawk
Copy link
Contributor Author

I don't think this test failing is this PR's fault

@grepsedawk grepsedawk force-pushed the jewelcrafting-level-5--autofix-unlocked branch from d3b2d5c to b75fe7b Compare December 26, 2021 07:45
test/fixers/test_crystal_format_fixer_callback.vader Outdated Show resolved Hide resolved
autoload/ale/fixers/crystal.vim Outdated Show resolved Hide resolved
@grepsedawk grepsedawk force-pushed the jewelcrafting-level-5--autofix-unlocked branch from 1ffea3d to 4472a4a Compare December 27, 2021 18:57
@grepsedawk grepsedawk force-pushed the jewelcrafting-level-5--autofix-unlocked branch from 4472a4a to 8cea112 Compare December 27, 2021 19:03
@grepsedawk
Copy link
Contributor Author

Sick, those changes worked.
Thank you, I was struggling to find the failing specs previously but I was able to spot them now.

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contrib.

@hsanson hsanson merged commit 48f6859 into dense-analysis:master Dec 28, 2021
@grepsedawk grepsedawk deleted the jewelcrafting-level-5--autofix-unlocked branch December 28, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants