-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue): volar v1 support #4552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use volar myself but changes look good and this is affecting many users. Merging so it can be further tested.
Thanks for the quick turnaround on this!
Specifically at the bottom, getting an exec check failure for the vue-language-server. I already have installed typescript in the package I am running; are there other dependencies? |
You need to have the vue-language-server installed globally with |
Ah it had to be global. Thanks a ton! |
* fix: volar v1 support * fix: volar linter errors
According to the discussion over on #4460 (reply in thread)
I've identified that volar v1 does have breaking changes.
Following the volar discussion (vuejs/language-tools#2279) I've adjusted the initialization options and added a warning message instructing the user to install
typescript
in the project in order for volar to work.