-
-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0 #148
3.0 #148
Conversation
promptinit will only load themes that has prompt_*_setup entry point and exists in fpath See https://git.io/vQOcT
This condition is identical to _is_git(). Was checking mistakenly.
Sometimes user may not have write access to zsh site functions directory, in those cases use ~/.zfunctions as fallback directory. It's also added to $fpath.
Make loading promptinit optional, Because some users may be already loading promptinit
…aceship-zsh-theme into feature/trunc-before-git
Use no-break whitespace in markdown docs
Docs for 3.0 (#148)
@salmanulfarzy @maximbaz @nfischer @RolfKoenders please, review this PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job 👍, Mentioning some nice-to-haves.
|
||
See [screenshots](https://github.com/denysdovhan/spaceship-prompt/wiki/Screenshots) wiki for more color schemes examples. | ||
|
||
## Does not help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention custom prompt order as solution if prompt feels slow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Congratulations! We have made it! It's only left to deprecate old |
@salmanulfarzy yep. I've fixed this. We should use absolute paths, not relative ones. |
Published as |
Please also update repo description. |
@salmanulfarzy updating descriptions, links, etc — everything in progress. |
Awesome! New goal - reach zero open PRs 😀 |
Spaceship just hit 1000★'s!
We've got a lot of feature PRs. More features → less performance. Time to update a bit the way how the spaceship works with its sections. Let's split a large main file into smaller parts (corresponding to sections).