Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 #148

Merged
merged 178 commits into from
Jan 18, 2018
Merged

3.0 #148

merged 178 commits into from
Jan 18, 2018

Conversation

denysdovhan
Copy link
Member

@denysdovhan denysdovhan commented Jun 24, 2017

Spaceship just hit 1000★'s!

We've got a lot of feature PRs. More features → less performance. Time to update a bit the way how the spaceship works with its sections. Let's split a large main file into smaller parts (corresponding to sections).

@denysdovhan denysdovhan added the improvement A PR that make small changes for improving UX, performance, readability, etc label Jun 24, 2017
@denysdovhan denysdovhan self-assigned this Jun 24, 2017
promptinit will only load themes that has prompt_*_setup entry point
and exists in fpath

See https://git.io/vQOcT
This condition is identical to _is_git(). Was checking mistakenly.
@denysdovhan denysdovhan modified the milestone: v3.0 Jun 24, 2017
Sometimes user may not have write access to zsh site functions directory,
in those cases use ~/.zfunctions as fallback directory. It's also added
to $fpath.
Make loading promptinit optional, Because some users may be already
loading promptinit
@denysdovhan
Copy link
Member Author

denysdovhan commented Jan 17, 2018

@salmanulfarzy @maximbaz @nfischer @RolfKoenders please, review this PR.

3.0 is ready to be released. I'm waiting for your approval.

Copy link
Contributor

@maximbaz maximbaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🎉

Copy link
Member

@salmanulfarzy salmanulfarzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job 👍, Mentioning some nice-to-haves.

CONTRIBUTING.md Outdated Show resolved Hide resolved

See [screenshots](https://github.com/denysdovhan/spaceship-prompt/wiki/Screenshots) wiki for more color schemes examples.

## Does not help?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention custom prompt order as solution if prompt feels slow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@denysdovhan
Copy link
Member Author

Congratulations! We have made it!

It's only left to deprecate old spaceship-zsh-theme package and publish a new one spaceship-prompt.

@salmanulfarzy
Copy link
Member

Is the GitBook ready ? Document browsing through repository leads to 404.

repo doc 404

@denysdovhan
Copy link
Member Author

@salmanulfarzy yep. I've fixed this. We should use absolute paths, not relative ones.

@denysdovhan
Copy link
Member Author

Published as v3.0.0!

@salmanulfarzy
Copy link
Member

Please also update repo description.

@denysdovhan
Copy link
Member Author

@salmanulfarzy updating descriptions, links, etc — everything in progress.

@maximbaz
Copy link
Contributor

Awesome! New goal - reach zero open PRs 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking ‼️ BREAKING CHANGES ‼️ All breaking changes go under major release. improvement A PR that make small changes for improving UX, performance, readability, etc
Development

Successfully merging this pull request may close these issues.

10 participants