-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for custom labels in the counter metric #62
Conversation
Amazing, thanks for your PR, let me have a look at the testing part, maybe I can figure out what's wrong 😄 |
Alright I think I figured it out. Turns out, unregistering is not sufficient as stated in the library documentation:
This is why when executed individually, the test passes, and why it fails when executed with others. |
Co-authored-by: Depado <Depado@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 247 257 +10
=========================================
+ Hits 247 257 +10 ☔ View full report in Codecov by Sentry. |
Thanks a lot for your PR 👍 |
|
Thanks for the review and for the release! |
Add support to custom labels for in the counter metric.
Closes #61
The test passes if you launch it alone, but fails when launching all with this message:
panic: a previously registered descriptor with the same fully-qualified name as...
I don't have enough experience with golang and the source code to fix it.