Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LH V0: Deprecate the /v1/facilities/va endpoint in vets-api #18487

Open
1 task
jilladams opened this issue Jul 10, 2024 · 1 comment
Open
1 task

LH V0: Deprecate the /v1/facilities/va endpoint in vets-api #18487

jilladams opened this issue Jul 10, 2024 · 1 comment
Assignees
Labels
Facilities API Vets-api API that powers Facilities products and the Facility Locator Facilities Facilities products (VAMC, Vet Center, etc) ghp-refine Lighthouse Facility API Data source/destination for many Facilities team products Needs refining Issue status points-3 Ruby sitewide Technical debt VA.gov frontend CMS team practice area

Comments

@jilladams
Copy link
Contributor

jilladams commented Jul 10, 2024

[2024-10-30] We cannot deprecate the whole legacy API client til we hear from Don (McCaughey?) on the mobile team. BUT: we may be able to deprecate this endpoint.

Description or Additional Context

Context: #18351

Should decommission and remove not the library but the endpoint for /v1/facilities/va

The legacy Facilities API client/library in vets-api has an active endpoint that references Lighthouse V0. We need to deprecate that, now that LH V0 has been deprecated

The legacy API client is very minimally documented here: https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/facilities/facilities-api#legacy-facilities-api-client

The code lives here: https://github.com/department-of-veterans-affairs/vets-api/tree/master/lib/lighthouse/facilities

Acceptance Criteria

  • /v1/facilities/va endpoint is no longer available in vets-api
@jilladams jilladams added Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status Lighthouse Facility API Data source/destination for many Facilities team products sitewide Ruby Facilities API Vets-api API that powers Facilities products and the Facility Locator labels Jul 10, 2024
@jilladams jilladams added Technical debt VA.gov frontend CMS team practice area labels Aug 16, 2024
@jilladams jilladams added Blocked Issues that are blocked on factors other than blocking issues. and removed Blocked Issues that are blocked on factors other than blocking issues. labels Oct 30, 2024
@jilladams
Copy link
Contributor Author

We may find ourselves blocked from removing htis endpoint, depending on how Mobile handled the legacy API client V1 upgrade. But Eli will check, and if it can be removed, we will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities API Vets-api API that powers Facilities products and the Facility Locator Facilities Facilities products (VAMC, Vet Center, etc) ghp-refine Lighthouse Facility API Data source/destination for many Facilities team products Needs refining Issue status points-3 Ruby sitewide Technical debt VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

2 participants