[DBEX] log when Form 0781 document upload fails #17625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeheeling
added
disability-experience
va-vfs-bot
temporarily deployed
to
dbex/87623-failed-0781-document-upload-logging/main/main
tblackwe
previously approved these changes
Jul 22, 2024
rmtolmach
reviewed
Jul 22, 2024
Comment on lines
+83
to
+93
|
|
||
| def status_updater(status, document_upload) | ||
| # UploadStatusUpdater encapsulates all parsing of a status response from Lighthouse | ||
| @status_updater ||= BenefitsDocuments::Form526::UploadStatusUpdater.new(status, document_upload) | ||
| end | ||
|
|
||
| def statsd_document_base_key(statsd_document_type_key) | ||
| @statsd_document_base_key ||= "#{STATSD_BASE_KEY}.#{statsd_document_type_key}" | ||
| end | ||
|
|
||
| def log_failure(document_upload) |
There was a problem hiding this comment.
Nice. I like that you pulled out some logic fromupdate_document_status and made these methods 🎉
rmtolmach
reviewed
Jul 22, 2024
| return unless document_upload.form0781_types? | ||
|
|
||
| submission = document_upload.form526_submission | ||
| Rails.logger.info( |
There was a problem hiding this comment.
Even though it's a failure, you want this at the info level?
There was a problem hiding this comment.
@rmtolmach Considering your posed question, in ef9e562, I've updated the log level to warn. Thanks!
rmtolmach
previously approved these changes
Jul 22, 2024
freeheeling
force-pushed
the
dbex/87623-failed-0781-document-upload-logging
branch
from
418d1cc
to
ef9e562
Compare
|
@rmtolmach Reposting...
|
rmtolmach
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Objective: Implements a system for periodically polling the Lighthouse uploads/status endpoint to confirm the status of supplemental documents submitted to Lighthouse as part of a Form 526 Submission. The purpose of this system is to surface successes and failures that happen in the Form 526 process after being forwarded to Lighthouse for processing.
form0781_types?instance method toLighthouse526DocumentUpload(includes test)update_document_statushelper method inUpdateDocumentsStatusServiceYES/NORelated issue(s)
Testing done
What areas of the site does it impact?
Acceptance criteria