Incorrect role on <dd> element on "On this page" component

[laflannery]

Bug Report

• I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

The "On this page" component has a role="definition assigned to the <dd> element:

I am asking that

1. If there is a very good reason we are using the definition list markup:
   • The role be removed from this element because:
     • As with all ARIA, we do not want or need to use a role when a semantic element is available
     • Also, because we are using a role that is not aligned with the semantic element we are using, the implicit value of the element is changing and this is being flagged as an error in AMP as an incorrect element being used within the <dl>
       
2. However, this markup seems complex for this, it's just a navigation element and there doesn't seem to be a reason why this wouldn't just use a simply list markup.
   • Recommendation to update this to a typical list markup and remove the definition list entirely

What I expected to happen

I would expect the markup to use only expected elements and to use the least complex markup appropriate for the content and information you are trying to convey

Reproducing

• Formation version:
• Device: (e.g. iPhone 8, Macbook)
• Browser: (e.g. Firefox, IE 11)

Steps to reproduce:

Urgency

How urgent is this request? Please select the approriate option below and/or provide details

• This bug is blocking work currently in progress
• This bug is affecting work currently in progress but we have a workaround
• This bug is blocking work planned within the next few sprints
• This bug is not blocking any work
• Other

Details

[caw310]

Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @nickjg231 @powellkerry @rmessina1010 @rsmithadhoc

[jamigibbs]

I think I agree with @laflannery about the existing dl markup. Looking over MDN, the description list doesn't seem appropriate. Maybe it was initially done that way because it could maybe be described as a glossary? But that doesn't seem exactly right for this use case either. Unfortunately I could not find any details about it when it was created so I'm not sure the original reason.

Here are the guidelines for nav which can contain any type of markup but a list is probably best here.

[Andrew565]

My plan is to convert this component to use a UL and LI elements.

[laflannery]

@Andrew565 Thank you so much for completing this, it's going to be so helpful with the AMP scans! For my purposes and so I can pass it along to others, do you know when this will be released to production?

[Andrew565]

We're in process to get it out to production tomorrow.