Prevent overriding default rails connection_specification_name ("primary") #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 5.2.0 introduced a change via rails/rails@0bd7f4a which reuses a connection object created before migration after migration. Because `reconnect_with_percona` does a new `establish_connection`, the existing default connection will be disconnected and replaced with percona_connection under the same connection_specification_name. Because rails now re-uses the connection object created before migration, this will raise exception because it was disconnected for percona. This commit tries to override the connection_specification_name, and hence the cached connection by rails will remain alive.
guilleiguaran
approved these changes
Apr 28, 2018
sauloperez
requested changes
Apr 30, 2018
There was a problem hiding this comment.
Can you please reflect this change somehow in the integration tests? I feel like we don't run the integration tests as we do in an actual migration and that might be a problem here.
Besides, I don't fully grasp how this relates to #with_advisory_lock and the connection var. If I understood correctly the problem is that at the time rails tries to release the lock the connection is released already, right?
Closed
muffinista
added a commit
to bandzoogle/departure
that referenced
this pull request
Mar 21, 2019
This is basically a cherry pick of departurerb#32
|
This is a simple change that seems important for the continued use of departure. I'm going to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31