Add mysql2 0.5.2 gem support #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Have you executed all the test suite using mysql2 0.5.2? |
|
Yes, as well as 0.5.1 @guilleiguaran |
|
@guilleiguaran is this something doable? |
|
IMO we should execute the test suite with at least mysql2 0.5.2. |
|
@sauloperez I ran the specs with mysql2 0.5.2 and 0.5.1 |
|
Sorry, I meant in CI. This way we ensure tests pass with the latest supported version. |
|
This PR ran travis with 0.5.2 https://travis-ci.org/departurerb/departure/builds/415922252#L616 |
|
Ouch, right! that good looks good to me then. Agree @guilleiguaran @wyhaines ? |
|
Looking good in my opinion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.