Implement capturing an image as PNG #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x40 is part of the command code, not all commands have it.
First query the sensor size using a new command, then capture an image, and save it as 8bit greyscale PNG file.
|
FWICT, the protocol matches pretty much exactly what's documented in https://gitlab.freedesktop.org/libfprint/libfprint/-/blob/master/libfprint/drivers/elan.h. So with that driver it might "just work". For elanmoc, which I guess is the preferred option, I can only spot small differences. Which problems did you run into when trying to enable support for 0c4c in there? |
|
Anyway, it's good that you figured out how to retrieve the PNG image since the Match-On-Chip functionality has the issues you can read about in the MR linked above. I'll take a look when I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got this sensor in my HP envy x360 15 model from 2021 and decided to play around a bit.
I don't have a windows installation to get USB traces, so I had a look at the driver and found a way (three different ones, actually, this one is to grab an image immediately) to get a raw 14bit image from the sensor.
Taking it a step further, with a quick-n-dirty PyQt GUI it's visible that it can capture at about 6-7fps, which is fun.