Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export detection (export x from y) #272

Merged
merged 8 commits into from
Oct 23, 2018
Merged

Add export detection (export x from y) #272

merged 8 commits into from
Oct 23, 2018

Conversation

mnkhouri
Copy link
Member

@mnkhouri mnkhouri commented Aug 13, 2018

This PR fixes #262 by adding a detector for Export Declarations.

Add (currently failing) tests for #262
@LinusU
Copy link
Member

LinusU commented Aug 13, 2018

Nice 👍

@mnkhouri mnkhouri added this to the 1.0.0 milestone Aug 20, 2018
@mnkhouri mnkhouri changed the title [WIP] Fix re-export detection (export x from y) Fix export detection (export x from y) Aug 28, 2018
@mnkhouri mnkhouri changed the title Fix export detection (export x from y) Add export detection (export x from y) Aug 28, 2018
@mnkhouri mnkhouri requested a review from LinusU August 28, 2018 01:54
@mnkhouri
Copy link
Member Author

tests are currently failing due to a 503 Service Temporarily Unavailable from coveralls.io, I'll retry the build later

* master:
  Upgrade all dependencies (#276)
  Fix error when Typescript is not installed (#282)
  Enable ES6/7 syntax in Typescript (#258)
  Update NPM tokens for deploy from Travis (#278)
  Recognize object arrays in Webpack module.rules.loaders (#233)
  Add support for import() expressions (#205)
  Bump Mocha to 5.x (#274)
  Fix ignore-bin-package default in ReadMe (#252)
  Fix typo: pasers -> parsers
@codecov
Copy link

codecov bot commented Aug 28, 2018

Codecov Report

Merging #272 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
+ Coverage   98.04%   98.05%   +<.01%     
==========================================
  Files          29       30       +1     
  Lines         461      462       +1     
==========================================
+ Hits          452      453       +1     
  Misses          9        9
Impacted Files Coverage Δ
src/constants.js 100% <ø> (ø) ⬆️
src/detector/exportDeclaration.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e32807...ce51810. Read the comment docs.

@mnkhouri mnkhouri requested review from lijunle and LinusU and removed request for LinusU September 7, 2018 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False "unused dependencies" for export ... from ...
3 participants