Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite our javascript helpers to use ESM #5684

Closed
jeffwidman opened this issue Sep 12, 2022 · 2 comments
Closed

Rewrite our javascript helpers to use ESM #5684

jeffwidman opened this issue Sep 12, 2022 · 2 comments

Comments

@jeffwidman
Copy link
Member

jeffwidman commented Sep 12, 2022

Some of our dependencies in the /npm_and_yarn/helpers are moving to only using ESM. And based on what I read in https://formidable.com/blog/2021/node-esm-and-exports/, this will likely become more common over time.

So we'll need to rewrite our javascript helpers to use ESM in order to update these deps.

At first glance, this is probably a good change, but a fair bit of busy work.

See also #4125 (comment)

@jeffwidman
Copy link
Member Author

jeffwidman commented Sep 13, 2022

I spent an hour and a half coming up to speed on ESM vs CommonJS this evening... There's definitely some controversy in the node community(!), but the migration path didn't look too horrible. Here was one of the better migration checklists.

That said, there may be some unexpected blockers that we run into, for example Jest doesn't fully support ESM.

Happy to accept a PR if someone wants to take a crack at it.

Copy link
Contributor

👋 This issue has been marked as stale because it has been open for 2 years with no activity. You can comment on the issue to hold stalebot off for a while, or do nothing. If you do nothing, this issue will be closed eventually by the stalebot. Please see CONTRIBUTING.md for more policy details.

@github-actions github-actions bot added the Stale label Sep 13, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant