Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enabled NamedSubject RSpec rule which was accidentlaly overwritten #10041

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

GarryHurleyJr
Copy link
Contributor

@GarryHurleyJr GarryHurleyJr commented Jun 19, 2024

What are you trying to accomplish?

The NamedSubject Rubocop rule was accidentally disabled after work had been completed on it. This will re-enable that cop for main so that we can avoid the rebasing issues we have come across

Anything you want to highlight for special attention from reviewers?

This change is merely putting a named subject in for the generic 'subject' designator.

How will you know you've accomplished your goal?

Resetting branches to main will include this rule in the enabled ruleset.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@GarryHurleyJr GarryHurleyJr merged commit 8b54d1c into main Jun 19, 2024
121 checks passed
@GarryHurleyJr GarryHurleyJr deleted the GarryHurleyJr/reenableNamedSubject branch June 19, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants