set Dockerfile WORKDIR to /home/dependabot to avoid permission errors when consumers of the dependabot-core image run bundle install #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when consumers of the dependabot-core image run bundle install
baseballlover723
force-pushed
the
pr/fix_docker
branch
from
122b02d
to
7ba4cba
Compare
sobolevn
reviewed
Apr 15, 2021
Dockerfile
Outdated
| BUNDLE_BIN=".bundle/bin" \ | ||
| PATH=".bundle/bin:$PATH:/home/dependabot/.bundle/bin" | ||
| ENV HOME=/home/dependabot | ||
| WORKDIR $HOME |
feelepxyz
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like #3398 ended up breaking some scripts that were using the dependabot-core image (such as https://github.com/wemake-services/kira-dependencies and https://github.com/dependabot/dependabot-script). Seems like someone just forgot to set the
WORKDIRwhich causespwdto be/, which causes dependabot to fail to bundle install, since it doesn't have permission to write to/. This just sets theWORKDIRto the dependabot's home directory so that all of the bundler stuff ends up in a place that dependabot owns.Note that now the bundler env variables are no longer needed, since they will just go into dependabots home directory.They are still needed, but I moved the directories to be in dependabot's home directory.I tested that this fixes wemake-services/kira-dependencies#265, and I strongly suspect that it will also fix dependabot/dependabot-script#574 as well.