Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version conventions #19

Closed
mfbmina opened this issue Aug 27, 2018 · 4 comments
Closed

Wrong version conventions #19

mfbmina opened this issue Aug 27, 2018 · 4 comments

Comments

@mfbmina
Copy link

mfbmina commented Aug 27, 2018

Acording semvem (https://semver.org/) the version conventions are:

x.y.z, where:

  • x: major
  • y: minor
  • x: patch

Depfu is calling minor updates as major. Eg: [ruby] Update mysql2: 0.4.10 → 0.5.2 (major)

@theflow
Copy link
Member

theflow commented Aug 27, 2018

Hi @mfbmina,

we actually had some feedback in the opposite direction and changed it. The truth is pre-1.0.0 there aren't a lot of rules :)

From our experience most library authors treat minor version jumps as major updates when they are pre 1.0.0. I think you can also see that here if you look at the release notes for mysq2 0.5.0 which has a lot of breaking changes: https://github.com/brianmario/mysql2/releases/tag/0.5.0

@mfbmina
Copy link
Author

mfbmina commented Aug 27, 2018

Hello!

I assume that I did not read the mysql release tag before creating this ticket. So, how Depfu see the diferences between major, minor and patch>

@theflow
Copy link
Member

theflow commented Aug 27, 2018

We do it exactly as you posted for everything after a 1.0.0 release. For everything still in the 0.x.x range semver states:

Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.

So we treat 0.4.0 -> 0.5.0 as a major update, since that what it is in most cases.

@mfbmina
Copy link
Author

mfbmina commented Aug 27, 2018

Thanks for the reply and the explanation. Also thanks for Depfu, it is an awesome product. 😄

@theflow theflow closed this as completed Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants