Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace phar build script with box-project/box2 build tool. #193

Closed
wants to merge 1 commit into from

Conversation

tomzx
Copy link
Contributor

@tomzx tomzx commented Feb 22, 2015

Adds a box.json file that should replace the configuration used in the build file.
Removes the old build file (since it is replaced by the configuration file).

File size goes from 3 MB to ~485 KB.

Reference: #190

Adds a box.json file that should replace the configuration used in the build file.
Removes the old build file (since it is replaced by the configuration file).
@antonmedv
Copy link
Member

What if i add $phar->compressFiles(Phar::GZ); to my build script?
Now deployer.org site uses my build script, so we need to refactoring them too.
What is the benefit ща migration to box2?

@antonmedv
Copy link
Member

New size of deployer.phar 825KB now.

I think we need to reduce number of dependencies.

@gordalina
Copy link
Contributor

Nice job @tomzx
Box really makes it simple to package an app.

I would like to add that enabling gzip compression could lead to php installations (without gzip extension enable), to fail loading the phar. Also Composer had an issue with this before.

Regarding the size of the phar, I guess we (developers) have reasonably fast bandwidth to transfer a larger file, thus making it less relevant.

@tomzx
Copy link
Contributor Author

tomzx commented Mar 4, 2015

@Elfet Why do you prefer your own build script to using a library that is used/tested by many? What would make you change your mind?

@antonmedv
Copy link
Member

Hmmm, i'll think about it :)

@gpupo
Copy link

gpupo commented May 22, 2015

I agree with @tomzx. Nice job

@antonmedv
Copy link
Member

Box awesome project, but i do not what to touch what's already good working.
Also i do not see any cons of this.

@antonmedv antonmedv closed this May 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants