Extract $releaseDatetime in order to share a common release datetime between parallel deployments. #203
Conversation
| while (is_dir(env()->parse($releasePath)) && $i < 42) { | ||
| $releasePath .= '.' . ++$i; | ||
| } | ||
|
|
There was a problem hiding this comment.
Is it really needed? And why stop at 42?
There was a problem hiding this comment.
Yes, it's needed in tests. Three times runs deploy:release and check all was correct.
42
|
Yes, this is good feature. But it will not working in parallel mode. I will implement distributed Deployer parameters, so it will be possible to implement correct solution for this in parallel deployment mode. |
|
Build fails. |
tomzx
force-pushed
the
features/shared-release-datetime
branch
from
9e0e1a2
to
0a32b19
Compare
|
@Elfet With the latest change, I've created an global variable called |
…between parallel deployments.
tomzx
force-pushed
the
features/shared-release-datetime
branch
from
0a32b19
to
902b53a
Compare
|
Or the VCSs revision/hash. Just saying 😄 |
|
If I'm not mistaken, the way Capistrano does it is to append the release identifier at the end of a file containing the list of releases when a release is successfully published. Whatever the identifier is, it'll be possible to figure out which release came before/after which one based on the ordering in the file. It shouldn't be too hard to implement this feature if enough people want it. |
|
Just tried it myself: Capistrano3 keeps a log of revision it deployed, but that seems to be just a log. $ cat revisions.log
Branch master (at bdd236b) deployed as release 20150318214035 by sebastianIt still creates the actual deployments into folders based on the timestamp and delete them in order. However, that doesn't me |
|
Will be implemented in Deployer v4. |
No description provided.