Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pub/static/_cache as shared_dir #3343

Merged
merged 1 commit into from
Jan 8, 2023
Merged

add pub/static/_cache as shared_dir #3343

merged 1 commit into from
Jan 8, 2023

Conversation

torhoehn
Copy link
Contributor

@torhoehn torhoehn commented Oct 11, 2022 •
edited

  • Bug fix #…?

  • New feature?

  • BC breaks?

  • Tests added?

  • Docs added?

    Please, regenerate docs by running next command:
$ php bin/docgen

pub/static/_cache should be declared as shared_dir, so it's possible to mount it between different app-servers
in a multi host setup.

Example:

  • run Magento with two app-servers (app-a / app-b)
  • route all admin request to app-a
  • cached css files will be generated on app-a and app-b
  • observe 404 responses for files of pub/static/_cache directory

@peterjaap
Copy link
Contributor

peterjaap commented Oct 11, 2022 •
edited

@torhoehn any reason why this is still a WIP? I agree with the PR overall.

@torhoehn
Copy link
Contributor Author

@peterjaap Wanted to test behaviour before the change again, but when you already agree I'll mark it as ready. 😀

@torhoehn torhoehn marked this pull request as ready for review October 11, 2022 17:30
@antonmedv antonmedv merged commit 492cd97 into deployphp:master Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjaap peterjaap Awaiting requested review from peterjaap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@torhoehn @peterjaap @antonmedv