DD#0000: feat: Magento2: Add support for preload keys #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonmedv
reviewed
Apr 6, 2023
schmengler
suggested changes
Jun 9, 2023
- Also updated to remove the config set and instead manually add the hocks to your deployer file - And move var-exporter into the main composer require - deployphp#3453 (comment)
…s beginning of string Updated readme use better grammer
schmengler
reviewed
Jul 3, 2023
| @@ -440,7 +440,7 @@ function magentoDeployAssetsSplit(string $area) | |||
| /** | |||
| * Update cache id_prefix on deploy so that you are compiling against a fresh cache | |||
| * Reference Issue: https://github.com/davidalger/capistrano-magento2/issues/151 | |||
| * use add the following to your deployer scripts: | |||
| * To use this feature, add the following to your deployer scripts: | |||
There was a problem hiding this comment.
forget my last comment, this is good now 😄
schmengler
approved these changes
Jul 3, 2023
|
Ok for me. Let's get 👍🏻 from someone with Magento experience and merge. |
schmengler
approved these changes
Jul 3, 2023
okolya
added a commit
to integer-net/deployer
that referenced
this pull request
Sep 29, 2023
* DD#0000: feat: Magento2: Add support for preload keys - Also updated to remove the config set and instead manually add the hocks to your deployer file - And move var-exporter into the main composer require - deployphp#3453 (comment) * DD#0000: feat: Reverted composer updates * DD#0000: feat: Updated docs * DD#0000: feat: Updated replace to use preg to make sure it only checks beginning of string Updated readme use better grammer * DD#0000: feat: Updated md docs (cherry picked from commit 48193c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated to remove the config set and instead manually add the hocks to your deployer file
And move var-exporter into the main composer require
Magento 2: Cache key id prefix #3453 (comment)
[ - ] Bug fix Magento 2: Cache key id prefix #3453 (comment)
New feature?
BC breaks?
Tests added?
[ - ] Docs added?