-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed wrong agent forwarding implementation (fixes #393) #428
Conversation
Fixed wrong agent forwarding implementation (fixes #393)
Thank you! 👍 |
👍 |
The new phpseclib has broken git clones for me. I'm using pemfiles for auth. Everything was fine with deployer/phpseclib:1.0.0 but now git clone produces empty directory. I switched to 3.0.7 and downgraded phpseclib back to 1.0.0 and everything works fine again. |
@AlexStansfield I will look at this problem ASAP. I guess problem is in phpseclib because of BC breaks. It's a pity that there are no test for this case in deployer. |
@torinaki thanks. I'm not sure what's going on I even built a version that didn't suppress git messages to see if it was at least giving me some useful output. Absolutely nothing. I'd imagine there are some pretty big changes between phpseclib 1.0.0 and 2.0.0 and something there has really messed things up for me. |
@AlexStansfield I can say, that deployer already have used 2.0.0 version of |
@torinaki actually v1.0.0 fork on deployer is from february 22nd. There have been many changes in phpseclib since then. https://github.com/deployphp/phpseclib/commits/v1.0.0 |
As for timeout. it consistently fails with v2.0.0 from phpspeclib and consistently works with v1.0.0 from deployer. And it only takes about 5 seconds to do the git clone. I'm not setting any timeout myself. Also it's not the clone that causes the deployer to fail. It's not until it tries to create a symlink to a shared file in a directory that doesn't exist (as it wasn't cloned by git) that an error is triggered. |
@AlexStansfield is this reproduceble with this fix: Actual changes here: |
Sorry I had left work. That fix breaks it more. When trying to connect to the server I get:
But replacing the timeout with with a high enough number (3600) did the trick. Thanks |
@AlexStansfield does it work now with 3.0.8? |
Really strange, because exactly same error I have notice when timeout was 0. @AlexStansfield how and where did you change that timeout? What PHP version you use? |
I took the 3.0.7 source and added PHP_INT_MAX as you suggested, it gave me that error. I then downloaded the 3.0.8 phar file and tried with no modifications and it gave me that error.
|
@AlexStansfield please upgrade till latest version 3.0.9. Fix already in master |
Yep that fixed it, cheers |
No description provided.