Skip to content
This repository has been archived by the owner on Apr 26, 2020. It is now read-only.

Phinx recipes #74

Closed
security-database opened this issue Nov 30, 2016 · 4 comments
Closed

Phinx recipes #74

security-database opened this issue Nov 30, 2016 · 4 comments

Comments

@security-database
Copy link

Hello

It seem that phinx recipe is not working anymore with deployer 4.0.

@antonmedv
Copy link
Member

Can you careate pr to fix it?

@security-database
Copy link
Author

security-database commented Nov 30, 2016

@Elfet
PR #76
Sorry about rewriting all Tasks, but couldn't make them work

-- Apologize for editing a lot this post.

@ketchoop
Copy link
Contributor

ketchoop commented Dec 1, 2016

@Elfet, it can be fixed by moving some functions to global scope from get/set. As I can see, you change a way to get closures from get/set(to call_user_func). Now the recipe can't pass arguments to them. How do you think, if I move functions from get/set, will it pollute global scope?

@antonmedv
Copy link
Member

What functions? Why not add namespace Deployer;

ketchoop added a commit to ketchoop/recipes that referenced this issue Dec 2, 2016
Fix with functions in 'set'

Add deployer namespace

Change docs according to v4 changes
antonmedv added a commit that referenced this issue Dec 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants