Skip to content
This repository has been archived by the owner on Apr 26, 2020. It is now read-only.

Cachetool fix for 4.X family and PHP version 7.1.X #256

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Cachetool fix for 4.X family and PHP version 7.1.X #256

merged 1 commit into from
Mar 31, 2020

Conversation

jespinal
Copy link
Contributor

After the release of the 5.X family of cachetool, cachetool.phar no longer refers to a member of 4.X family, but to the last tag of the new family instead. This introduces an error when cachetool is executed from an environment with PHP 7.1.X, as the new cachetool.phar works with PHP >=7.2.

E.g.

$ php71 /var/www/[...]/cachetool.phar --version
PHP Fatal error:  Uncaught Error: Call to undefined function Symfony\Component\Console\Output\stream_isatty() in phar:///var/www/[...]/cachetool.phar/vendor/symfony/console/Output/StreamOutput.php:117
Stack trace:
#0 phar:///var/www/[...]/cachetool.phar/vendor/symfony/console/Output/StreamOutput.php(52): Symfony\Component\Console\Output\StreamOutput->hasColorSupport()
#1 phar:///var/www/[...]/cachetool.phar/vendor/symfony/console/Output/ConsoleOutput.php(42): Symfony\Component\Console\Output\StreamOutput->__construct(Resource id #71, 32, NULL, NULL)
#2 phar:///var/www/[...]/cachetool.phar/vendor/symfony/console/Application.php(118): Symfony\Component\Console\Output\ConsoleOutput->__construct()
#3 phar:///var/www/[...]/ in phar:///var/www/[...]/cachetool.phar/vendor/symfony/console/Output/StreamOutput.php on line 117

So, at this point we have 3 (or more), not 2, possible paths:

  1. CacheTool 3.x which works with PHP >=5.5.9
  2. CacheTool 4.x works with PHP >=7.1
  3. CacheTool 5.x works with PHP >=7.2 (referred to in the recipe as cachetool.phar)
MODIFICATIONS:
  • Fixed cachetool recipe by adding the ability to pick a release from the 4.X family which is now intended for PHP >=7.1
Q A
Bug fix? Yes
New feature? No
BC breaks? No
Deprecations? No
Fixed tickets N/A

- Fixed cachetool recipe by adding the ability to pick a release from the 4.X family, which is now intended for PHP >=7.1
@antonmedv antonmedv merged commit 91c080e into deployphp:master Mar 31, 2020
@jespinal jespinal deleted the 20200331-cachetool-fix-for-4.X-family branch April 1, 2020 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants