feat(@shared/toks-components): Input 컴포넌트 임시 개발 #77

chaaerim · 2022-11-23T21:33:53Z

💡 왜 PR을 올렸나요?

shared/toks-components에 Input 컴포넌트를 만들었습니다.
컬러들은 반영했는데 label이나 error message를 작업하는 과정에서 prime react를 사용하지 않고 직접 커스텀을 하는 것이 맞는지 의문이 들어 풀리퀘 날립니다.
inactive
hover
focused
invalid

💁 무엇이 어떻게 바뀌나요?

💬 리뷰어분들께

커스텀이 생각보다 어렵네요 조언 주시면 감사하겠습니다.

LineGu · 2022-11-23T21:37:56Z

😭 테스트가 실패했습니다.

GitHub Actions 확인하기

패키지명: @depromeet/toks-components
위치: shared/toks-components

stdout:


/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/Button/index.tsx
  55:1  warning  Unexpected 'TODO' comment: 'TODO: 다크 모드 대응'                   no-warning-comments
  59:7  warning  Unexpected 'TODO' comment: 'TODO: inline style로 적용한 부분 제외하기'  no-warning-comments

/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/GlobalStyle/index.tsx
  17:1  warning  Unexpected 'TODO' comment: 'TODO: 1. @depromeet/theme로 옮기기 2. color...'  no-warning-comments

/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/Input/index.tsx
   3:1   error  `@emotion/styled` import should occur before import of `primereact/inputtext`   import/order
   4:1   error  `@depromeet/theme` import should occur before import of `primereact/inputtext`  import/order
   5:1   error  There should be at least one empty line between import groups                   import/order
   5:1   error  `@emotion/react` import should occur before import of `primereact/inputtext`    import/order
  18:25  error  'type' is assigned a value but never used                                       @typescript-eslint/no-unused-vars

/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/SSRSuspense/index.tsx
  8:12  warning  Fragments should contain more than one child - otherwise, there’s no need for a Fragment at all  react/jsx-no-useless-fragment

/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/Tag/index.tsx
  13:7  warning  Unexpected 'TODO' comment: 'TODO: inline style로 적용한 부분 제외하기'  no-warning-comments
  44:1  warning  Unexpected 'TODO' comment: 'TODO: maxView 개수 받도록'             no-warning-comments

/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/Text/index.tsx
  13:19  warning  Unexpected 'TODO' comment: 'TODO: color token type 추가'  no-warning-comments
  18:1   warning  Unexpected 'TODO' comment: 'TODO: 폰트 토큰 정해지면 수정하기'      no-warning-comments

✖ 13 problems (5 errors, 8 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

에러 트레이스 (stderr):

Command failed with exit code 1: yarn workspace @depromeet/toks-components run lint

LineGu · 2022-11-23T21:41:27Z

😭 테스트가 실패했습니다.

GitHub Actions 확인하기

패키지명: @depromeet/toks-components
위치: shared/toks-components

stdout:


/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/Button/index.tsx
  55:1  warning  Unexpected 'TODO' comment: 'TODO: 다크 모드 대응'                   no-warning-comments
  59:7  warning  Unexpected 'TODO' comment: 'TODO: inline style로 적용한 부분 제외하기'  no-warning-comments

/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/GlobalStyle/index.tsx
  17:1  warning  Unexpected 'TODO' comment: 'TODO: 1. @depromeet/theme로 옮기기 2. color...'  no-warning-comments

/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/Input/index.tsx
   2:1   error  There should be no empty line within import group                              import/order
   4:1   error  There should be no empty line within import group                              import/order
   6:1   error  There should be no empty line within import group                              import/order
   8:1   error  `@emotion/styled` import should occur before import of `primereact/inputtext`  import/order
  22:25  error  'type' is assigned a value but never used                                      @typescript-eslint/no-unused-vars

/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/SSRSuspense/index.tsx
  8:12  warning  Fragments should contain more than one child - otherwise, there’s no need for a Fragment at all  react/jsx-no-useless-fragment

/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/Tag/index.tsx
  13:7  warning  Unexpected 'TODO' comment: 'TODO: inline style로 적용한 부분 제외하기'  no-warning-comments
  44:1  warning  Unexpected 'TODO' comment: 'TODO: maxView 개수 받도록'             no-warning-comments

/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/Text/index.tsx
  13:19  warning  Unexpected 'TODO' comment: 'TODO: color token type 추가'  no-warning-comments
  18:1   warning  Unexpected 'TODO' comment: 'TODO: 폰트 토큰 정해지면 수정하기'      no-warning-comments

✖ 13 problems (5 errors, 8 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

에러 트레이스 (stderr):

Command failed with exit code 1: yarn workspace @depromeet/toks-components run lint

LineGu · 2022-11-25T06:20:15Z

😭 테스트가 실패했습니다.

GitHub Actions 확인하기

패키지명: @depromeet/toks-components
위치: shared/toks-components

stdout:


/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/Button/index.tsx
  55:1  warning  Unexpected 'TODO' comment: 'TODO: 다크 모드 대응'                   no-warning-comments
  59:7  warning  Unexpected 'TODO' comment: 'TODO: inline style로 적용한 부분 제외하기'  no-warning-comments

/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/GlobalStyle/index.tsx
  17:1  warning  Unexpected 'TODO' comment: 'TODO: 1. @depromeet/theme로 옮기기 2. color...'  no-warning-comments

/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/Input/index.tsx
   5:1   error  There should be at least one empty line between import groups                  import/order
   5:1   error  `@emotion/styled` import should occur before import of `primereact/inputtext`  import/order
  18:25  error  'type' is assigned a value but never used                                      @typescript-eslint/no-unused-vars

/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/SSRSuspense/index.tsx
  8:12  warning  Fragments should contain more than one child - otherwise, there’s no need for a Fragment at all  react/jsx-no-useless-fragment

/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/Tag/index.tsx
  13:7  warning  Unexpected 'TODO' comment: 'TODO: inline style로 적용한 부분 제외하기'  no-warning-comments
  44:1  warning  Unexpected 'TODO' comment: 'TODO: maxView 개수 받도록'             no-warning-comments

/home/runner/work/toks-web/toks-web/shared/toks-components/src/components/Text/index.tsx
  13:19  warning  Unexpected 'TODO' comment: 'TODO: color token type 추가'  no-warning-comments
  18:1   warning  Unexpected 'TODO' comment: 'TODO: 폰트 토큰 정해지면 수정하기'      no-warning-comments

✖ 11 problems (3 errors, 8 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

에러 트레이스 (stderr):

Command failed with exit code 1: yarn workspace @depromeet/toks-components run lint

LineGu · 2022-11-25T09:31:23Z

shared/toks-components/src/components/Input/index.tsx

+      <Text size={14} weight={400}>
+        {errorMessage}
+      </Text>


errorMessage != null ?
{errorMessage}
: null

chaaerim added 2 commits November 24, 2022 04:24

✨ feat: InputText에 디자인 시스템 적용

feee7c6

✨ feat: input 컴포넌트

25d53f5

chaaerim requested review from LineGu, minsgy and dengoyoon as code owners November 23, 2022 21:33

LineGu assigned chaaerim Nov 23, 2022

LineGu enabled auto-merge (squash) November 23, 2022 21:34

🐛 fix: delete dead code

d1c1af1

🐛 fix: import 순서 변경

65c60e9

🐛 fix: import 사이 공백 제거

46d61dd

🐛 fix: yarn lint fix

7880e36

LineGu approved these changes Nov 26, 2022

View reviewed changes

Merge branch 'master' into feat/Input

9803fa3

LineGu merged commit edaf670 into master Nov 26, 2022

LineGu deleted the feat/Input branch November 26, 2022 08:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(@shared/toks-components): Input 컴포넌트 임시 개발 #77

feat(@shared/toks-components): Input 컴포넌트 임시 개발 #77

chaaerim commented Nov 23, 2022

LineGu commented Nov 23, 2022

LineGu commented Nov 23, 2022

LineGu commented Nov 25, 2022

LineGu Nov 25, 2022

feat(@shared/toks-components): Input 컴포넌트 임시 개발 #77

feat(@shared/toks-components): Input 컴포넌트 임시 개발 #77

Conversation

chaaerim commented Nov 23, 2022

💡 왜 PR을 올렸나요?

💁 무엇이 어떻게 바뀌나요?

💬 리뷰어분들께

LineGu commented Nov 23, 2022

😭 테스트가 실패했습니다.

LineGu commented Nov 23, 2022

😭 테스트가 실패했습니다.

LineGu commented Nov 25, 2022

😭 테스트가 실패했습니다.

LineGu Nov 25, 2022

Choose a reason for hiding this comment