Skip to content
This repository has been archived by the owner on Jul 27, 2018. It is now read-only.

What To Expect: Loading / Moving Day - clear up confusion about signing in the remarks section #397

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

jamesatheyDDS
Copy link
Contributor

Addresses #390.

Checklist

I have…

  • run the application locally (bin/rails server) and verified that my changes behave as expected.
  • run static code analysis (bin/rubocop) and vulnerability scan (bin/brakeman) against my changes.
  • run the test suite (bin/rake spec) and verified that all tests pass.
  • summarized below my changes and noted which issues (if any) this pull request fixes or addresses.
  • thoroughly outlined below the steps necessary to test my changes.
  • attached screenshots illustrating relevant behavior before and after my changes.
  • read, understand, and agree to the terms described in CONTRIBUTING.md.

Summary of Changes

This pull request rearranges the words at the end of the "Loading / Moving Day" section in "What To Expect" for CONUS moves. It no longer implies signing in the remarks section.

Testing

To verify the changes proposed in this pull request…

  1. clone this repo,
  2. git checkout wte_remarks_signing,
  3. set up development dependencies according to CONTRIBUTING.md,
  4. run bin/rails server, and
  5. load up http://localhost:3000 in the Web browser of your choice.

Screenshots

Before:

screen shot 2018-03-23 at 12 07 05 pm

After:

screen shot 2018-03-23 at 12 06 45 pm

@lfantano
Copy link

lfantano commented Mar 23, 2018 via email

@jamesatheyDDS jamesatheyDDS merged commit cab96a0 into master Mar 23, 2018
@jamesatheyDDS jamesatheyDDS deleted the wte_remarks_signing branch March 23, 2018 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants