feat: tag 'review-items' as 'best-practice' (#1344)

AdnoC · web-flow · commit 05f37de193de · 2019-02-01T11:00:20.000-05:00
diff --git a/doc/rule-descriptions.md b/doc/rule-descriptions.md
@@ -30,11 +30,11 @@
 | empty-heading                       | Ensures headings have discernible text                                                                                     | Minor              | cat.name-role-value, best-practice                                           | true               |
 | focus-order-semantics               | Ensures elements in the focus order have an appropriate role                                                               | Minor              | cat.keyboard, best-practice, experimental                                    | true               |
 | form-field-multiple-labels          | Ensures form field does not have multiple label elements                                                                   | Moderate           | cat.forms, wcag2a, wcag332                                                   | true               |
-| frame-tested                        | Ensures &lt;iframe&gt; and &lt;frame&gt; elements contain the axe-core script                                              | Critical           | cat.structure, review-item                                                   | true               |
+| frame-tested                        | Ensures &lt;iframe&gt; and &lt;frame&gt; elements contain the axe-core script                                              | Critical           | cat.structure, review-item, best-practice                                    | true               |
 | frame-title-unique                  | Ensures &lt;iframe&gt; and &lt;frame&gt; elements contain a unique title attribute                                         | Serious            | cat.text-alternatives, best-practice                                         | true               |
 | frame-title                         | Ensures &lt;iframe&gt; and &lt;frame&gt; elements contain a non-empty title attribute                                      | Serious            | cat.text-alternatives, wcag2a, wcag242, wcag412, section508, section508.22.i | true               |
 | heading-order                       | Ensures the order of headings is semantically correct                                                                      | Moderate           | cat.semantics, best-practice                                                 | true               |
-| hidden-content                      | Informs users about hidden content.                                                                                        | Minor              | cat.structure, experimental, review-item                                     | true               |
+| hidden-content                      | Informs users about hidden content.                                                                                        | Minor              | cat.structure, experimental, review-item, best-practice                      | true               |
 | html-has-lang                       | Ensures every HTML document has a lang attribute                                                                           | Serious            | cat.language, wcag2a, wcag311                                                | true               |
 | html-lang-valid                     | Ensures the lang attribute of the &lt;html&gt; element has a valid value                                                   | Serious            | cat.language, wcag2a, wcag311                                                | true               |
 | html-xml-lang-mismatch              | Ensure that HTML elements with both valid lang and xml:lang attributes agree on the base language of the page              | Moderate           | cat.language, wcag2a, wcag311                                                | true               |
diff --git a/lib/rules/frame-tested.json b/lib/rules/frame-tested.json
@@ -1,7 +1,7 @@
 {
 	"id": "frame-tested",
 	"selector": "frame, iframe",
-	"tags": ["cat.structure", "review-item"],
+	"tags": ["cat.structure", "review-item", "best-practice"],
 	"metadata": {
 		"description": "Ensures <iframe> and <frame> elements contain the axe-core script",
 		"help": "Frames must be tested with axe-core"
diff --git a/lib/rules/hidden-content.json b/lib/rules/hidden-content.json
@@ -2,7 +2,7 @@
 	"id": "hidden-content",
 	"selector": "*",
 	"excludeHidden": false,
-	"tags": ["cat.structure", "experimental", "review-item"],
+	"tags": ["cat.structure", "experimental", "review-item", "best-practice"],
 	"metadata": {
 		"description": "Informs users about hidden content.",
 		"help": "Hidden content on the page cannot be analyzed"

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"id": "frame-tested",`
`3`	`3`	`"selector": "frame, iframe",`
`4`		`- "tags": ["cat.structure", "review-item"],`
	`4`	`+ "tags": ["cat.structure", "review-item", "best-practice"],`
`5`	`5`	`"metadata": {`
`6`	`6`	`"description": "Ensures <iframe> and <frame> elements contain the axe-core script",`
`7`	`7`	`"help": "Frames must be tested with axe-core"`